Feat: Notifications Banner #184
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
M-ZubairAhmed
requested changes
Sep 19, 2024
lindalumitchell
approved these changes
Oct 12, 2024
| "folder": "notifications-banner", | ||
| "tests": [ | ||
| "Enable Desktop notification on Window/Mac/Ubuntu Desktop app", | ||
| "Enable/Disabled notification on Mobile app" |
There was a problem hiding this comment.
Suggested change
| "Enable/Disabled notification on Mobile app" | |
| "Enable/Disable notification on Mobile app" |
| authors: "@yasserfaraazkhan" | ||
| team_ownership: | ||
| - ICU | ||
| priority_p1_to_p4: P2 - Core Functions (Do core functions work?) |
There was a problem hiding this comment.
Suggested change
| priority_p1_to_p4: P2 - Core Functions (Do core functions work?) | |
| priority_p1_to_p4: P3 - Deep Functions (Do extensive scenarios work?) |
|
|
||
| **Step 1** | ||
|
|
||
| ### Scenario: User Enable's the desktop notifications |
There was a problem hiding this comment.
Suggested change
| ### Scenario: User Enable's the desktop notifications | |
| ### Scenario: User Enables the desktop notifications |
| 11. Open Settings modal. Expand "Desktop and mobile notification section". | ||
| 12. Verify "Desktop notifications aren’t enabled" message is not visible anymore. | ||
|
|
||
| ### Scenario: User Deny's the desktop notifications on WINDOWS / MAC / Ubuntu OS |
There was a problem hiding this comment.
Suggested change
| ### Scenario: User Deny's the desktop notifications on WINDOWS / MAC / Ubuntu OS | |
| ### Scenario: User Denies the desktop notifications on WINDOWS / MAC / Ubuntu OS |
| 6. Verify a confirmation pop up is shown with message `Mattermost(<Instance link>) would like to send you notifications.`. | ||
| 7. **Deny** the notifications permissions. | ||
| 8. Receive a notification ping from another user. | ||
| 9. Verify the notification pop-up are not seen. |
There was a problem hiding this comment.
Suggested change
| 9. Verify the notification pop-up are not seen. | |
| 9. Verify the notification pop-up is not seen. |
| 10. Verify the Global banner is not visible anymore. | ||
| 11. Open Settings modal. | ||
| 12. Verify a Alert tag is visible, saying "Permission required". | ||
| 13. Expand "Desktop and mobile notification section". |
There was a problem hiding this comment.
Suggested change
| 13. Expand "Desktop and mobile notification section". | |
| 13. Expand "Desktop and mobile notifications" section. |
| 13. Expand "Desktop and mobile notification section". | ||
| 14. Verify "Desktop notifications permission was denied" message is visible. A buttons with text "Enable desktop notifications" and "How to enable notifications" are visible. | ||
|
|
||
| ### Scenario: User Deny's the desktop notifications on Browsers Chrome/Safari/Firefox/Edge |
There was a problem hiding this comment.
Suggested change
| ### Scenario: User Deny's the desktop notifications on Browsers Chrome/Safari/Firefox/Edge | |
| ### Scenario: User Denies the desktop notifications on browsers Chrome/Safari/Firefox/Edge |
| @@ -0,0 +1,53 @@ | |||
| --- | |||
| # (Required) Ensure all values are filled up | |||
| name: "Enable/Disabled notification on Mobile app" | |||
There was a problem hiding this comment.
Suggested change
| name: "Enable/Disabled notification on Mobile app" | |
| name: "Enable/Disable notification on Mobile app" |
| authors: "@yasserfaraazkhan" | ||
| team_ownership: | ||
| - ICU | ||
| priority_p1_to_p4: P2 - Core Functions (Do core functions work?) |
There was a problem hiding this comment.
Suggested change
| priority_p1_to_p4: P2 - Core Functions (Do core functions work?) | |
| priority_p1_to_p4: P3 - Deep Functions (Do extensive scenarios work?) |
M-ZubairAhmed
added
the
Do Not Merge
|
Adding this here since we have some more changes to be added with Desktop specific |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira: https://mattermost.atlassian.net/browse/MM-60477